fix onevict #51
Merged
fix onevict #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlmcguire
requested review from
jarifibrahim and
manishrjain
as code owners
golangcibot
reviewed
Sep 22, 2019
karlmcguire
commented
Sep 22, 2019
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @golangcibot, @jarifibrahim, and @manishrjain)
cache_test.go, line 108 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
S1019: should use make(map[uint64]int) instead (from
gosimple)
Done.
karlmcguire
commented
Sep 22, 2019
There was a problem hiding this comment.
Dismissed @golangcibot from a discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jarifibrahim and @manishrjain)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #49
I also added a test to make sure this bug won't pop up again.
This change is