This repository has been archived by the owner on Jul 18, 2024. It is now read-only.
Add Iterate for allocation-free iteration #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `Iterate` method to the bitmap that accepts a callback function for each value in the bitmap. If the callback function returns false, the iteration is halted This pattern allows for iterating the bitmap with 0 allocations: ``` name time/op Iterator-8 1.35ms ± 4% Iterate-8 374µs ± 5% name alloc/op Iterator-8 4.65MB ± 0% Iterate-8 0.00B name allocs/op Iterator-8 30.0 ± 0% Iterate-8 0.00 ``` This commit also fixes the existing `BenchmarkIterate` function to correctly benchmark the iterator
|
|
|
@ahsanbarkati thoughts here? |
ahsanbarkati
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
@kevinconaway The change looks good to me. We also want to make the current type based iterator to be able to run without allocations. The plan is to keep a couple of pointers (for the key and the index in the container) as the iterator state.
| // Iterate iterates over the bitmap, calling the given callback with each value in the bitmap. If the callback returns | ||
| // false, the iteration is halted. | ||
| // The iteration results are undefined if the bitmap is modified (e.g., with Set or Remove). | ||
| // There is no guarantee as to what order the values will be iterated |
There was a problem hiding this comment.
Why? The iteration will be in sorted order, right?
|
This change is no more needed. An iterator has been already implemented which does iteration without allocations and keeps the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
Iteratemethod to the bitmap that accepts a callback function for each value in the bitmap. If the callback function returns false, the iteration is haltedThis pattern allows for iterating the bitmap with 0 allocations:
This commit also fixes the existing
BenchmarkIteratefunction to correctly benchmark the iteratorThis change is