Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule: NoMandatoryConstructorInExceptionClass #19

Merged

Conversation

dykov
Copy link
Collaborator

@dykov dykov commented Jan 8, 2022

Description

A new rule has been implemented to check if an exception class has constructors with required signature:
public Ctor(Throwable, String, Object...) or public Ctor(String, Object...)

class MyException extends Exception {
    public MyException(String pattern, Object... args) {}

    public MyException(Throwable cause, String pattern, Object... args) {}
}

Completed work

  • Added new rule
  • Added new unit tests
  • Passed all checks

Related issues:

Implements #3

@dykov dykov requested a review from dgroup January 8, 2022 20:01
@dykov dykov self-assigned this Jan 8, 2022
@dykov dykov added the enhancement New feature or request label Jan 8, 2022
@dgroup
Copy link
Owner

dgroup commented Jan 8, 2022

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 8, 2022

@rultor merge

@dgroup OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 59d2c78 into dgroup:master Jan 8, 2022
@rultor
Copy link
Collaborator

rultor commented Jan 8, 2022

@rultor merge

@dgroup Done! FYI, the full log is here (took me 2min)

@dykov dykov added the new rule label Feb 4, 2022
@dgroup dgroup modified the milestone: 0.1.0 Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new rule
Projects
None yet
3 participants