Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-minitest requirement from = 0.17.1 to = 0.17.2 #581

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 14, 2022

Updates the requirements on rubocop-minitest to permit the latest version.

Release notes

Sourced from rubocop-minitest's releases.

RuboCop Minitest 0.17.2

Bug fixes

  • #159: Fix a false positive for Minitest/UnreachableAssertion when using only one assertion method in assert_raises block. (@​koic)
Changelog

Sourced from rubocop-minitest's changelog.

0.17.2 (2022-02-12)

Bug fixes

  • #159: Fix a false positive for Minitest/UnreachableAssertion when using only one assertion method in assert_raises block. ([@​koic][])

0.17.1 (2022-01-30)

Changes

  • #158: Make Minitest/UnreachableAssertion aware of assert and refute prefix methods. ([@​koic][])

0.17.0 (2021-11-23)

New features

  • #155: Provide assert_offense, assert_correction, and assert_no_offenses testing APIs for custom Minitest cop development. ([@​koic][])

0.16.0 (2021-11-14)

New features

  • #147: Add EnforcedStyle config parameter for Minitest/GlobalExpectations. ([@​gi][])

Bug fixes

  • #142: Fix Minitest/GlobalExpectations autocorrect when receiver is lambda. ([@​gi][])
  • #150: Fix a false positive for Minitest/AssertEmpty and RefuteEmpty cops when using empty method with any arguments. ([@​koic][])

0.15.2 (2021-10-11)

Bug fixes

  • #145: Mark Minitest/AssertEmptyLiteral as safe auto-correction. ([@​koic][])

0.15.1 (2021-09-26)

Bug fixes

  • #143: Fix an error for Minitest/LiteralAsActualArgumentTest when expected and actual arguments are literals. ([@​koic][])

0.15.0 (2021-08-09)

New features

  • #140: Make Minitest/AssertNil and Minitest/RefuteNil aware of assert(obj.nil?) and refute(obj.nil?). ([@​koic][])

0.14.0 (2021-07-03)

New features

... (truncated)

Commits
  • 093a9fd Cut 0.17.2
  • fa60f06 Update Changelog
  • 9b888e0 Merge pull request #160 from koic/fix_false_positive_for_minitest_unreachable...
  • d5c7c12 [Fix #159] Fix a false positive for Minitest/UnreachableAssertion
  • c3f9ddb Switch back docs version to master
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rubocop-minitest](https://github.com/rubocop/rubocop-minitest) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop-minitest/releases)
- [Changelog](https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-minitest@v0.17.1...v0.17.2)

---
updated-dependencies:
- dependency-name: rubocop-minitest
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #581 (4a48a68) into master (1018f2c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #581   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files          57       57           
  Lines        1640     1640           
=======================================
  Hits         1421     1421           
  Misses        219      219           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1018f2c...4a48a68. Read the comment docs.

@dgroup dgroup added this to the 0.13.0 milestone Feb 15, 2022
@dgroup
Copy link
Owner

dgroup commented Feb 15, 2022

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 15, 2022

@rultor merge

@dgroup OK, I'll try to merge now. You can check the progress of the merge here

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 15, 2022

Looks like rubocop-minitest is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Feb 15, 2022
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-minitest-eq-0.17.2 branch February 15, 2022 19:28
@rultor
Copy link
Collaborator

rultor commented Feb 15, 2022

@rultor merge

@dgroup Done! FYI, the full log is here (took me 4min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants