Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from = 1.28.2 to = 1.29.0 #611

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 9, 2022

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.29

New features

Bug fixes

  • #10586: Fix a false positive for Style/DoubleNegation when using define_method or define_singleton_method. (@​ydah)
  • #10579: Fix a false positive for Style/FetchEnvVar when calling a method with safe navigation`. (@​koic)
  • #10581: Fix a false positive for Style/FetchEnvVar when comparing with ENV['TERM']. (@​koic)
  • #10589: Fix autocorrect for Style/RaiseArgs with EnforcedStyle: compact and exception object is assigned to a local variable. (@​nobuyo)
  • #10325: Enhance Style/RedundantCondition by considering the case that variable assignments in each branch. (@​nobuyo)
  • #10592: Fix infinite loop on Style/MultilineTernaryOperator if using assignment method and condition/branch is multiline. (@​nobuyo)
  • #10536: Fix validation for command-line options combination of --display-only-fail-level-offenses and --auto-correct. (@​nobuyo)

Changes

Changelog

Sourced from rubocop's changelog.

1.29.0 (2022-05-06)

New features

Bug fixes

  • #10586: Fix a false positive for Style/DoubleNegation when using define_method or define_singleton_method. ([@​ydah][])
  • #10579: Fix a false positive for Style/FetchEnvVar when calling a method with safe navigation`. ([@​koic][])
  • #10581: Fix a false positive for Style/FetchEnvVar when comparing with ENV['TERM']. ([@​koic][])
  • #10589: Fix autocorrect for Style/RaiseArgs with EnforcedStyle: compact and exception object is assigned to a local variable. ([@​nobuyo][])
  • #10325: Enhance Style/RedundantCondition by considering the case that variable assignments in each branch. ([@​nobuyo][])
  • #10592: Fix infinite loop on Style/MultilineTernaryOperator if using assignment method and condition/branch is multiline. ([@​nobuyo][])
  • #10536: Fix validation for command-line options combination of --display-only-fail-level-offenses and --auto-correct. ([@​nobuyo][])

Changes

  • #10577: (Compatibility) Drop support for Ruby 2.5 and JRuby 9.2 (CRuby 2.5 compatible). ([@​koic][])
  • #10585: Enhance the autocorrect for Style/FetchEnvVar. ([@​johnny-miyake][])
  • #10577: (Breaking) Retire Lint/UselessElseWithoutRescue cop. ([@​koic][])

1.28.2 (2022-04-25)

Bug fixes

  • #10566: Fix a false positive for Lint/AmbiguousBlockAssociation when using proc is used as a last argument. ([@​koic][])
  • #10573: Fix a false positive for Layout/SpaceBeforeBrackets when there is a dot before brackets. ([@​nobuyo][])
  • #10563: Fix Style/BlockDelimiters unexpectedly deletes block on moving comment if methods with block are chained. ([@​nobuyo][])
  • #10574: Fix a false positive for Style/SingleArgumentDig when using dig with arguments forwarding. ([@​ydah][])
  • #10565: Fix a false positive and a true negative for Style/FetchEnvVar. ([@​koic][])

1.28.1 (2022-04-21)

Bug fixes

  • #10559: Fix crash on CodeLengthCalculator if method call is not parenthesized. ([@​nobuyo][])
  • #10557: Fix a false positive for Style/FetchEnvVar when ENV['key'] is a receiver of ||=. ([@​koic][])

1.28.0 (2022-04-21)

New features

... (truncated)

Commits
  • 2f2b2a7 Cut 1.29
  • e6a5a94 Update Changelog
  • 1b6bda4 Support the cases that there is a method call in each branch
  • 070ffea [Fix #10325] Enhance Style/RedundantCondition by considering the case that ...
  • 3439417 Remove an old reference to version 1.0
  • 5b7c91b Tweak uniformity of expression was implemented
  • 914551a [Fix #10568] Add new Style/EnvHome cop
  • 0d23a0a Tweak highlight offense range for InternalAffairs/MethodNameEndWith cop
  • 73dfcf2 Merge pull request #10600 from nobuyo/add-new-internal-affairs-method-name-en...
  • 6eadcd9 Add new InternalAffairs/MethodNameEndWith cop
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.28.2...v1.29.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dgroup
Copy link
Owner

dgroup commented May 9, 2022

@rultor merge

@rultor
Copy link
Collaborator

rultor commented May 9, 2022

@rultor merge

@dgroup OK, I'll try to merge now. You can check the progress of the merge here

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 9, 2022

Looks like rubocop is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this May 9, 2022
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-eq-1.29.0 branch May 9, 2022 09:47
@rultor
Copy link
Collaborator

rultor commented May 9, 2022

@rultor merge

@dgroup Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants