Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-performance requirement from = 1.13.3 to = 1.14.0 #615

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 24, 2022

Updates the requirements on rubocop-performance to permit the latest version.

Release notes

Sourced from rubocop-performance's releases.

RuboCop Performance 1.14.0

Bug fixes

  • #289: Fix a false positive for Performance/StringIdentifierArgument when using namespaced class string argument. (@​koic)
  • #288: Recover Ruby 2.4 code analysis using TargetRubyVersion: 2.4. (@​koic)

Changes

Changelog

Sourced from rubocop-performance's changelog.

1.14.0 (2022-05-24)

Bug fixes

  • #289: Fix a false positive for Performance/StringIdentifierArgument when using namespaced class string argument. ([@​koic][])
  • #288: Recover Ruby 2.4 code analysis using TargetRubyVersion: 2.4. ([@​koic][])

Changes

  • #287: (Compatibility) Drop Ruby 2.5 support. ([@​koic][])

1.13.3 (2022-03-05)

Bug fixes

  • #285: Fix an error for Performance/MapCompact when using map(&:do_something).compact.first and there is a line break after map.compact and receiver. ([@​ydah][])

1.13.2 (2022-01-16)

Bug fixes

  • #281: Fix an error for Performance/BlockGivenWithExplicitBlock when using Ruby 3.1's anonymous block forwarding. ([@​koic][])

1.13.1 (2022-01-01)

Bug fixes

  • #278: Fix a false positive for Performance/StringIdentifierArgument when using attr. ([@​koic][])

1.13.0 (2021-12-25)

New features

  • #276: Add new Performance/StringIdentifierArgument cop. ([@​koic][])
  • #204: Add Performance/Sum option to ignore potential false positives. ([@​leoarnold][])
  • #269: Add #to_d support to BigDecimalWithNumericArgument. ([@​leoarnold][])

Bug fixes

  • #277: Fix an incorrect autocorrect for Performance/MapCompact when using map.compact.first and there is a line break after map.compact and receiver. ([@​koic][])
  • #273: Fix an incorrect autocorrect for Performance/RedundantStringChars when using str.chars[0]. ([@​koic][])

Changes

  • #270: Mark Performance/Sum auto-correction as unsafe and extend documentation. ([@​leoarnold][])
  • #274: Unmark AutoCorrect: false from Performance/CaseWhenSplat. ([@​koic][])
  • #275: Unmark AutoCorrect: false from Performance/TimesMap. ([@​koic][])

1.12.0 (2021-10-31)

... (truncated)

Commits
  • 1dedfd3 Cut 1.14.0
  • b86dd9d Update Changelog
  • df84b2f Change "auto-correct" to "autocorrect"
  • 9dba637 Merge pull request #290 from koic/fix_a_false_positive_for_performance_string...
  • b0b47e7 [Fix #289] Fix a false positive for Performance/StringIdentifierArgument
  • 11dd588 Merge pull request #288 from koic/recover_ruby_24_analysis
  • c7ba54e Recover Ruby 2.4 code analysis using TargetRubyVersion: 2.4
  • 6738d9a Suppress InternalAffairs/CopDescription offenses
  • f175777 Unify to remove "This cop" from cop description in default.yml
  • 9d309f0 Enable Naming/InclusiveLanguage with CheckStrings: true
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rubocop-performance](https://github.com/rubocop/rubocop-performance) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-performance@v1.13.3...v1.14.0)

---
updated-dependencies:
- dependency-name: rubocop-performance
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #615 (55def5d) into master (56fe3b1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #615   +/-   ##
=======================================
  Coverage   86.54%   86.54%           
=======================================
  Files          57       57           
  Lines        1642     1642           
=======================================
  Hits         1421     1421           
  Misses        221      221           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56fe3b1...55def5d. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented May 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dgroup dgroup added this to the 0.13.0 milestone May 25, 2022
@dgroup
Copy link
Owner

dgroup commented May 25, 2022

@rultor merge

@rultor
Copy link
Collaborator

rultor commented May 25, 2022

@rultor merge

@dgroup OK, I'll try to merge now. You can check the progress of the merge here

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 25, 2022

Looks like rubocop-performance is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this May 25, 2022
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-performance-eq-1.14.0 branch May 25, 2022 15:17
@rultor
Copy link
Collaborator

rultor commented May 25, 2022

@rultor merge

@dgroup Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants