Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from = 1.30.0 to = 1.30.1 #620

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 6, 2022

Updates the requirements on rubocop to permit the latest version.

Changelog

Sourced from rubocop's changelog.

1.30.1 (2022-06-06)

Bug fixes

  • #10685: Fix a false positive for Style/StringConcatenation when Mode: conservative and first operand is not string literal. ([@​koic][])
  • #10670: Fix a false positive for Style/FetchEnvVar in the body with assignment method. ([@​ydah][])
  • #10671: Fix an incorrect autocorrect for EnforcedStyle: with_first_argument of Layout/ArgumentAlignment and EnforcedColonStyle: separator of Layout/HashAlignment. ([@​koic][])
  • #10676: Fix --ignore-unrecognized-cops option always showing empty warning even if there was no problem. ([@​nobuyo][])
  • #10674: Fix a false positive for Naming/AccessorMethodName with type of the first argument is other than arg. ([@​ydah][])
  • #10679: Fix a false positive for Style/SafeNavigation when TargetRubyVersion: 2.2 or lower. ([@​koic][])

Changes

  • #10673: Update auto-gen-config's comment re auto-correct for SafeAutoCorrect: false. ([@​ydah][])

1.30.0 (2022-05-26)

New features

  • #10065: Add new Gemspec/DeprecatedAttributeAssignment cop. ([@​koic][])
  • #10608: Add new Style/MapCompactWithConditionalBlock cop. ([@​nobuyo][])
  • #10627: Add command-line option --ignore-unrecognized-cops to ignore any unknown cops or departments in .rubocop.yml. ([@​nobuyo][])
  • #10620: Add Sorbet's typed sigil as a magic comment. ([@​zachahn][])

Bug fixes

  • #10662: Recover Ruby 2.1 code analysis using TargetRubyVersion: 2.1. ([@​koic][])
  • #10396: Fix autocorrect for Layout/IndentationWidth to leave module/class body unchanged to avoid infinite autocorrect loop with Layout/IndentationConsistency when body trails after class/module definition. ([@​johnny-miyake][])
  • #10636: Fix false positive in Style/RedundantCondition when the branches call the same method on different receivers. ([@​dvandersluis][])
  • #10651: Fix autocorrect for Style/For when using array with operator methods as collection. ([@​nobuyo][])
  • #10629: Fix default Ruby version from 2.5 to 2.6. ([@​koic][])
  • #10661: Fix a false negative for Style/SymbolProc when method has no arguments and AllowMethodsWithArguments: true. ([@​koic][])
  • #10631: Fix autocorrect for Style/RedundantBegin. ([@​johnny-miyake][])
  • #10652: Fix a false positive for Style/FetchEnvVar in conditions. ([@​ydah][])
  • #10665: Fix an incorrect autocorrect for EnforcedStyle: with_first_argument of Layout/ArgumentAlignment and EnforcedColonStyle: separator of Layout/HashAlignment. ([@​koic][])
  • #10258: Recover Ruby 2.4 code analysis using TargetRubyVersion: 2.4. ([@​koic][])
  • #10668: Recover Ruby 2.0 code analysis using TargetRubyVersion: 2.0. ([@​koic][])
  • #10644: Recover Ruby 2.2 code analysis using TargetRubyVersion: 2.2. ([@​koic][])
  • #10639: Fix Style/HashSyntax to exclude files that violate it with EnforceHashShorthandSyntax when running auto-gen-config. ([@​nobuyo][])
  • #10633: Fix infinite autocorrection loop in Style/AccessorGrouping when combining multiple of the same accessor. ([@​dvandersluis][])
  • #10618: Fix LineBreakCorrector so that it won't remove a semicolon in the class/module body. ([@​johnny-miyake][])
  • #10646: Fix an incorrect autocorrect for Style/SoleNestedConditional when using unless and && without parens in the outer condition and nested modifier condition. ([@​koic][])
  • #10659: Fix automatically appended path for inherit_from by auto-gen-config is incorrect if specified config file in a subdirectory as an option. ([@​nobuyo][])
  • #10640: Recover Ruby 2.3 code analysis using TargetRubyVersion: 2.3. ([@​koic][])
  • #10657: Fix --auto-gen-config command option ignores specified config file by option. ([@​nobuyo][])

Changes

  • #10095: Change "auto-correct" to "autocorrect" in arguments, documentation, messages, comments, and specs. ([@​chris-hewitt][])
  • #10656: Mark Style/RedundantInterpolation as unsafe autocorrection. ([@​koic][])

... (truncated)

Commits
  • 6f3ccdd Cut 1.30.1
  • f62c415 Update Changelog
  • e61ee78 Merge pull request #10695 from ydah/change_suggest_rake_task_warning
  • def56cb Change command for the rake task with arguments to a style that can also be u...
  • fa78663 Fix SafeMode deprecation version in the changelog (#10690)
  • 0c7a1aa Move default enforced styles to top in docs
  • a9fd669 Add a check for EnforcedStyle: (default) examples
  • 35d0d2b Merge pull request #10688 from koic/fix_a_false_positive_for_style_string_con...
  • 0a91fb2 [Fix #10685] Fix a false positive for Style/StringConcatenation
  • a5de777 Merge pull request #10674 from ydah/fix_a_false_positive_accessor_method_name
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

Merging #620 (750fdeb) into master (cc2218a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #620   +/-   ##
=======================================
  Coverage   86.54%   86.54%           
=======================================
  Files          57       57           
  Lines        1642     1642           
=======================================
  Hits         1421     1421           
  Misses        221      221           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2218a...750fdeb. Read the comment docs.

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.30.0...v1.30.1)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-eq-1.30.1 branch from 3ca02e0 to 750fdeb Compare June 10, 2022 19:33
@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dgroup
Copy link
Owner

dgroup commented Jun 21, 2022

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jun 21, 2022

@rultor merge

@dgroup OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Jun 21, 2022

@rultor merge

@dgroup Done! FYI, the full log is here (took me 3min)

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 21, 2022

Looks like rubocop is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Jun 21, 2022
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-eq-1.30.1 branch June 21, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants