Update travis config; add a build with dev tidyr #60
Conversation
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 9 9
Lines 397 397
=======================================
Hits 371 371
Misses 26 26Continue to review full report at Codecov.
|
jennybc
changed the title
| warnings_are_errors: true | ||
| sudo: required |
There was a problem hiding this comment.
This isn't needed / recommended these days.
| - r: release | ||
| name: tidyr-devel | ||
| before_script: Rscript -e "remotes::install_github('tidyverse/tidyr')" | ||
| - r: oldrel |
There was a problem hiding this comment.
This seems like a good basic build matrix (R devel, release, and oldrel). Technically, you should probably change the R version in DESCRIPTION to reflect the actively-tested versions. Our policy in the Tidyverse is to only claim what we actually test (but we also test on a larger matrix, which is probably overkill for many other packages). Thus I have not modified the current declaration of Depends: R (>= 2.10).
I've added a 2nd build with the released version of R that also checks against the dev version of tidyr. You might not want this in place all the time, but it's handy when a major dependency is nearing a release with breaking changes. I decided to demo this here in fuzzyjoin.
This is a legitimate PR and it's good to go.
But I'd also like to point other package maintainers to this as an example of how to start checking their package under released and dev versions of tidyr, as we roll towards the release of v1.0.0.