PyString::data(): return the internal representation of the Python unicode object
#247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctions for access to raw data of unicode objects.
…unicode object This fixes #246: panic in `PyString::to_string` and `PyString::to_string_lossy` when a Python3 unicode string contains unpaired surrogates.
markbt
approved these changes
Jan 15, 2021
| let data = py_string.cast_as::<PyString>(py).unwrap().data(py); | ||
| #[cfg(feature = "python3-sys")] | ||
| { | ||
| if let PyStringData::Latin1(s) = data { |
There was a problem hiding this comment.
Is it worth adding tests for the other PyStringData variants? I assume non-Latin-1 text (e.g. something in Greek) would be Utf16 and non-BMP text (e.g. something with emojis) would be Utf32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #246: panic in
PyString::to_stringandPyString::to_string_lossywhen a Python3 unicode string contains unpaired surrogates.As an optimization,
PyString::to_stringkeeps usingPyUnicode_AsUTF8AndSizewhich allows Python to cache the UTF-8 representation.