-
-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enabling support for arm/v6 #1708
Comments
That is correct, here is a working branch if you want to help #1697 otherwise I have no time and no idea how to fix it :( sorry |
You can publicly see the build step here and see how it failed |
@dgtlmoon: I believe the issue shown in the Github actions run you referenced is meanwhile fixed in pyyaml v6.0.1 via block Cython 3.0+ as a build dep. At least for me, the following worked fine locally (and it likely broke when you tried it some days back): docker buildx build --platform=linux/arm/v7 . However, there seems to be another/different issue with arm/v6 meanwhile, related to I guess, that leaves a couple of options:
Not sure which way to go - thoughts? |
I was also able to build the latest unmodified master branch on an rpi arm/v7. |
ARMv7 Looks OK #1713 But ARMv6+ARMv7 Does not https://github.com/dgtlmoon/changedetection.io/actions/runs/5727409864 I'll merge in ARMv7 support again, thanks for that, and I'll keep this ticket open for v6 |
Thank you very much, @dgtlmoon, for the prompt follow-up! The arm/v6 error is consistent with what I'm getting locally. Thus, I believe, out of the three options I listed, for arm/v6 we could...
Any preference for which one to pick? I won't be able to take another look during the next few days but if you have a preference, I could give it a try. |
(preferred) Fine by me.. I would prefer this if it fixes an upstream bug in
Maybe, but only if it doesn't affect the build/image size.. unsure, likely to cause problems I think |
#1713 merged, bringing back |
|
An issue has been filled on piwheels: piwheels/packages#380 |
@dgtlmoon, @marceloalencar: With piwheels/packages#380 marked as fixed for arm/v6, I wonder if the version pinning of jsonschema done in #1724 could/should be undone? |
Yes, once #1782 is applied. Otherwise it will always try to compile from source. |
Describe the bug
Thank you very much for building changedetection.io!
I saw that c35cbd3 reads "Removing docker build for RaspberryPi (arm/v6 and arm/v7) for now due to packaging problems". I was wondering if there is some more background regarding the packaging problems so that I can potentially support investigating to eventually get arm/v6 and arm/v7 support back in.
Version
v0.44 docker image at https://hub.docker.com/r/dgtlmoon/changedetection.io/tags.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
0.44: Pulling from dgtlmoon/changedetection.io ... Digest: sha256... Status: Image is up to date for dgtlmoon/changedetection.io:0.44 docker.io/dgtlmoon/changedetection.io:0.44
Screenshots
n/a
Desktop (please complete the following information):
n/a
Smartphone (please complete the following information):
n/a
Additional context
Worked up until (including) 0.43.2.
The text was updated successfully, but these errors were encountered: