-
-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Make RSS Feeds adhere to Notification settings #2131
Comments
The problem is (i think i wrote elsewhere also), that the 'difference' is calculated when the notification is sent. So what this means for RSS, is that basically every time you fetch the RSS feed, you might have 100 differences that need to be recalculated for each watch in the list someone would have to check the performance impact there, maybe add some benchmark logging to the notification render/difference section of the code |
This issue reads more or less a duplicate of #327 |
I would be totally fine without a diff in the notification. All I really was looking for is the watch_url to be included in the RSS feed. |
Oh snap, that is a bit annoying, that's an easy fix, i'll add that right away |
Thanks! |
@meichthys does this RSS template help? https://github.com/dgtlmoon/changedetection.io/pull/2139/files#diff-36cc0ceeaa435edb2f9fd2fd958397749fdd36cc4801b3c3a3c66fd28eae3be6R387 here it will provide a |
Boom. YES! @dgtlmoon It would be nice to be able to configure that template myself, but that change would be a HUGE help for me. And now that i know where that template is in the codebase, i can play with it on my own 👍 |
Cool, this is good for now, next step will be to have a (maybe you are watching with your RSS browser, but you also have email notification for some certain keyword setup etc) |
Thank you for this great tool!
Version and OS
0.45.13 on linux/docker
Is your feature request related to a problem? Please describe.
As a new user of changedetection I was expecting the content of the RSS feed to match the notification settings in changedetection. I was quite confused when i couldn't seem to change the Rss feed output to include the {watch_url} which is by default part of the notification output.
Describe the solution you'd like
I'd like to see RSS feeds adhere to the settings defined on the Notifications tab. Right now this is how my "Notification Body" is supposed to look like, but the setting seems to have no effect on the RSS feed, which is my preferred channel for reviewing changedetection updates:
Describe the use-case and give concrete real-world examples
When viewing an rss feed I would like to be able to click on a link to take me to the
watch_url
instead of the changedetection diff page.Additional context
Resolving this issue would also resolve #327
The text was updated successfully, but these errors were encountered: