-
-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System should timeout on badly formed regex's - freezes on adding ignore text filter with a badly formed regex #2268
Comments
the problem is this regex specifically can you explain what this is for? |
|
the problem is your regex, the other problem is that the system doesnt timeout, the regex works but it takes an exponentially long time to use. your regex is bad and the system doesnt catch it. the fix is to place the call to
maybe something like
|
I am not good at regex. It was created by ChatGPT4. My intention was to ignore lines that has just number or space. Below is entire ChatGPT 4 response.
|
Following works and should be better as per ChatGPT4.
|
I guess this is the classic old problem of pasting code that you dont understand fully. |
So true. Exactly why a good software should have all kinds of safety nets wherever it allows user's to inject code in a input box. Your proposed solution to timeout and throw error looks good. |
Describe the bug
Software freezes on adding specific ignore text on a specific website
Version
0.45.16
To Reproduce
Steps to reproduce the behavior:
Can't use share button because everything freezes as soon as above filter is added.
Expected behavior
All of the software should not freeze. If there some issue with ignore text or with the URL/website, it should not impact complete software.
Additional context
Note that above filter was added as global filter to thousands of watches but this issue is only with this one URL. It took us a while to zero down to this one URL.
The text was updated successfully, but these errors were encountered: