Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Text Filtering not displaying filters when watched site is added to a group with filters. #2307

Closed
Dragonatorul opened this issue Apr 14, 2024 · 2 comments · Fixed by #2311

Comments

@Dragonatorul
Copy link

Describe the bug
Given a watched website with text filters, if it is added to a group which has filters too, the text filters in the website edit page do not show anymore, but are applied.
The system default is playwright.

Version
v0.45.17

To Reproduce

Steps to reproduce the behavior:

  1. Create a group with CSS filter and remove path filter.
  2. Add a website link in the "Add a new change detection watch" field and assign the group you just created to it.
  3. Click on "Edit > Watch"
  4. In the "Filters & Triggers" tab, in the "Text Filters" section, add a text filter to "Trigger/wait for text" and to "Extract text"
  5. Save
  6. Wait for the website to be scraped
  7. Edit the watched website entry.
  8. In the "Filters & Triggers" tab, the text filters in "Trigger/wait for text" and to "Extract text" are not visible, but are being applied to the final result.

! ALWAYS INCLUDE AN EXAMPLE URL WHERE IT IS POSSIBLE TO RE-CREATE THE ISSUE - USE THE 'SHARE WATCH' FEATURE AND PASTE IN THE SHARE-LINK!

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Mac Sonoma 14.4.1
  • Browser Firefox
  • Version 128

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@dgtlmoon
Copy link
Owner

thanks for that! I should be able to improve the existing automated test to detect this case aswell

@dgtlmoon dgtlmoon changed the title Text Filtering not displaying filters when watched site is added to a group with filters. UI - Text Filtering not displaying filters when watched site is added to a group with filters. Apr 16, 2024
@dgtlmoon
Copy link
Owner

image

Now it will give a warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants