Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basic tag/group handling with filters+notifications #1610

Merged
merged 61 commits into from Jun 19, 2023
Merged

basic tag/group handling with filters+notifications #1610

merged 61 commits into from Jun 19, 2023

Conversation

dgtlmoon
Copy link
Owner

@dgtlmoon dgtlmoon commented May 31, 2023 •
edited

data model tag becomes tags

  • Make Watch::all_tags work with datastore
  • Add Test (with 'add tag' in ui)
  • Integrate with watch fetch
  • make sure it's backward compatible somehow (solved by using tags over tag)
  • fix 'recheck all in tag'
  • add update path
  • add notifications
  • 'delete' tag option
  • 'mute' tag option
  • add test for search
  • 'add to tag name' option

does flask have some auto-translate way for get arguments to convert name to tag-uuid?

dgtlmoon
dgtlmoon commented Jun 19, 2023
View reviewed changes
changedetectionio/__init__.py Outdated
@@ -1111,7 +1122,7 @@ def get_backup():
) as f:
for uuid in datastore.data["watching"]:
url = datastore.data["watching"][uuid]["url"]
tag = datastore.data["watching"][uuid]["tag"]
tag = datastore.data["watching"][uuid]["tags"]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace with .get()

dgtlmoon
dgtlmoon commented Jun 19, 2023
View reviewed changes
changedetectionio/__init__.py Outdated
@@ -1267,7 +1278,7 @@ def form_watch_checknow():
elif tag != None:
# Items that have this current tag
for watch_uuid, watch in datastore.data['watching'].items():
if (tag != None and tag in watch['tag']):
if (tag != None and tag in watch['tags']):
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.get also

@dgtlmoon dgtlmoon changed the title basic tag/group handling with filters basic tag/group handling with filters+notifications Jun 19, 2023
@dgtlmoon dgtlmoon merged commit 52f2c00 into master Jun 19, 2023
4 checks passed
@dgtlmoon dgtlmoon deleted the groups-basic branch June 19, 2023 21:29
This was referenced Jun 20, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dgtlmoon