Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add piwheels support for ARMv6 and ARMv7 machines" #1964

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Revert "Add piwheels support for ARMv6 and ARMv7 machines" #1964

merged 1 commit into from
Nov 11, 2023

Conversation

marceloalencar
Copy link
Contributor

Reverts to building packages as a part of GitHub actions.
I realized piwheels provides incompatible packages to the python:3.11-slim-bookworm Docker container used by changedetection, and this broke Docker releases on ARM devices.
I apologize for any inconvenience caused.

@dgtlmoon
Copy link
Owner

@marceloalencar hey, "piwheels provides incompatible packages "

do you have some examples or errors you can paste thats caused by this?

@marceloalencar
Copy link
Contributor Author

The docker container fails to start and restarts indefinitely with logs saying:
ImportError: cannot import name 'etree' from 'lxml' (/usr/local/lib/python3.11/site-packages/lxml/__init__.py)
Further investigation: piwheels/packages#409

@bennuttall
Copy link

piwheels only builds for armhf

@dgtlmoon
Copy link
Owner

ok, hmm is this ready to merge?

note - i rely totally on others to support rPi, i have no way to test it myself other than testing the docker build

@dgtlmoon
Copy link
Owner

if anyone knows how i can run a built docker container for each architecture in github... then I could build and test under emulation of each ARM type etc

@marceloalencar
Copy link
Contributor Author

marceloalencar commented Nov 11, 2023

ok, hmm is this ready to merge?

yes, ready to merge.

@dgtlmoon dgtlmoon merged commit 5f030d3 into dgtlmoon:master Nov 11, 2023
3 checks passed
@dgtlmoon
Copy link
Owner

ok, hmm is this ready to merge?

yes, ready to merge.

@marceloalencar ok merged, can you test the latest dgtlmoon/changedetection.io:dev works when https://github.com/dgtlmoon/changedetection.io/actions/runs/6836227017 is complete?

@marceloalencar
Copy link
Contributor Author

if anyone knows how i can run a built docker container for each architecture in github... then I could build and test under emulation of each ARM type etc

This seems promising: https://github.com/marketplace/actions/arm-runner

@marceloalencar marceloalencar deleted the undo-piwheels branch November 11, 2023 21:34
@marceloalencar
Copy link
Contributor Author

@marceloalencar ok merged, can you test the latest dgtlmoon/changedetection.io:dev works when https://github.com/dgtlmoon/changedetection.io/actions/runs/6836227017 is complete?

dgtlmoon/changedetection.io:dev (sha256:2db759807bde0deea2ecb04a6216c29545ca4738e614c99d6bef8ddfcc574885) works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants