Corporation fixes #139
Merged
Corporation fixes #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeuhV1
changed the title
dguenms
requested changes
Jan 16, 2017
There was a problem hiding this comment.
I don't think I want the Great People lists to be visible in the civilopedia. Discovering all the names that exist should be part of the game, and a reward for getting those GPs, in my opinion.
Can you separate the actual bug fixes from this pull request so I can approve them on their own? Everything looks fine there for me.
|
Done |
dguenms
requested changes
Jan 16, 2017
| @@ -102,6 +102,7 @@ def __init__(self): | |||
| self.W_INFLUENCES_AREA = self.X_CITY2_AREA + self.W_CITY_AREA - self.X_INFLUENCES_AREA | |||
| self.H_INFLUENCES_AREA = self.H_REQUIREMENTS_AREA | |||
| self.INFLUENCES_ID = "InfluencessAreaWidget" | |||
| self.iCorporationTech = iCorporation | |||
There was a problem hiding this comment.
I suggest to solve this using
from Consts import *
from Consts import iCorporation as iCorporationTech
Should work iirc. At least the iCorporationTech shouldn't be a member variable of the CvCorporationScreen class.
dguenms
approved these changes
Jan 16, 2017
|
Incorporated (pun intended) suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed wrong buttons in corporation advisor
Fixed corpotion pedia page when playing Brazil
REQUIRES RECOMPILING THE DLL