Improved Great People

[etiennefd]

At first I was going to simply correct a few mistakes here and there, and maybe add some names I could think of. I ended up adding quite a lot.

Highlights:

• fixed many spelling mistakes, missing diacritics, missing first names, missing feminine markers, wrong types of GP, wrong eras, and names that were not in their native language
• the German merchant and engineer lists were identical; I split them and added several names
• added some non-prophet names for Tibet, then realized Tibet uses Chinese lists, and figured I'd leave the names in anyway
• tried to improve ancient or poorly known civilization lists (Egypt, Babylon, Phoenicia, Aztecs), which often include random ruler names that have nothing to do with their type. It's better now, especially for artists and scientists, though it's still not perfect.

~ Steb

[dguenms]

Overall really great changes, both all the minor bugs and misspellings you caught and the new additions and era adjustments.

Only some minor comments, we can merge after you have addressed them.

[dguenms]

Maybe we should add a split into the classical era with the 4th century BC onwards?

[dguenms]

👍

[dguenms]

According to Wikipedia, the correct transliteration is Shoutoku Taishi. DoC consistently uses wapuro romaji for transliteration, where long o = ou.

[dguenms]

Ryouma (see above).

[dguenms]

Oukubo (see above).

[dguenms]

With the current code, Tibet won't use these entries, but the Chinese lists instead (there is a special rule coded into the getAlias() method above). We can change this, but I'm not sure if it's better to only have one name in your list.

[AppVeyorBot]

❌ Build Dawn-of-Civilization 1.14.127-cungyppv failed (commit 5fb955c7b6 by @etiennefd)

[etiennefd]

Thanks for your comments! They should now be addressed.

I have to disagree that DoC "consistently uses wapuro romaji for transliteration", since the long o's were represented by "o" in all Japanese names except the three I changed! But according to your preference (which is not the same as mine), I changed all of them to "ou".

The only proper response to your comment on Tibetan names, of course, was do some research and make decent lists for all categories. (Some names, like Yeshe Tsogyal and Tsongkhapa, probably fit more as prophets, but I didn't want to mess up the Dalai-Lama concept.)

[dguenms]

Thanks for changing the Japanese names. You're right that "consistently" is a bit of an overstatement, but it is my preferred standard (considering Civ4 cannot render the appropriate diacritic), and stuff like city names already adheres to the rule pretty strictly, so names should too.

Good call on keeping the prophets limited to dalai lamas, it's mostly that way to improve immersion when playing the Tibetan UHV. So for the moment we are agreed to keep the other Tibetan GP names, but keep them disabled, until the lists are further expanded?

[etiennefd]

I think there are sufficient Tibetan names now, and in fact I took the initiative to remove the getAlias() line already. Your call.

[dguenms]

Oh sorry, haven't even looked into the code again yet. That's indeed an impressive list! Merge coming.