Improved Great People 5 #199
Conversation
chinese names
…ls, Dutch, USA, Poland, Canada
Assets/Python/GreatPeople.py
Outdated
| @@ -275,40 +336,70 @@ def setup(): | |||
| "Jamshetji Tata", # 19th | |||
| "Ardeshir Godrej", # 19th | |||
| iGlobal, | |||
| "V. O. Chidambaram Pillai", # 20th | |||
There was a problem hiding this comment.
Can you find a form of the name that isn't too long without initials?
There was a problem hiding this comment.
Valliappan Olaganathan Chidambaram Pillai is a little long, isn't it? Apparently he's also known as Kappalottiya Tamizhan, "The Tamil Helmsman", so I'll put that.
Assets/Python/GreatPeople.py
Outdated
| iRenaissance, | ||
| "fRani Durgavati", # 16th | ||
| "Shivaji Bhosle", # 17th |
There was a problem hiding this comment.
Why did you remove him? The LH is Shahuji.
There was a problem hiding this comment.
Interesting. The XML tags say Shivaji, which is what I had checked, plus the fact that Shivaji seemed like a more important figure. The civilopedia also has a piece on Shivaji, not on Shahuji. The XML text however is Shahuji, and so is the constant in Consts.py. I'll put Shivaji back in the GP list, but what is the intention here?
| @@ -606,59 +696,146 @@ def setup(): | |||
| }, | |||
| iCivPersia : { | |||
| iGreatProphet : [ | |||
| "Zoroaster", # 18-10th BC | |||
| "Mahabad", # legendary | |||
| "Zarathustra", # 18-10th BC | |||
Assets/Python/GreatPeople.py
Outdated
| iMedieval, | ||
| "Al-Khwarizmi", # 9th | ||
| "Al-Razi", # 9th | ||
| "Muhammad ibn Musa al-Khwarizmi", # 9th |
There was a problem hiding this comment.
If the "last name" is well known I think it's best to leave it at that.
There was a problem hiding this comment.
I use Wikipedia titles as a heuristic to choose the best name to use, unless that name is not in the native language of the civ, but in this case I'm reverting it.
Assets/Python/GreatPeople.py
Outdated
| ], | ||
| iGreatEngineer : [ | ||
| "Artaxerxes", # 5th BC | ||
| u"Artaxsaça", # 4th BC |
There was a problem hiding this comment.
I would prefer the more phonetic transliteration "Artakhshathra" (see here)
Assets/Python/GreatPeople.py
Outdated
| "Xerxes", # 5th BC | ||
| "Mehrdad", # 2nd BC | ||
| "Haxamanis", # 7th BC | ||
| "Xsaya-rsa", # 5th BC |
Assets/Python/GreatPeople.py
Outdated
| ], | ||
| iGreatGeneral : [ | ||
| "William the Conqueror", # 11th | ||
| "Richard the Lionheart", # 12th | ||
| "William Wallace", # 13th |
There was a problem hiding this comment.
I don't think Scottish figures before unification should be included (especially those who fought against England)
Assets/Python/GreatPeople.py
Outdated
| iGlobal, | ||
| "fMata Hari", # 20th | ||
| "Dirk Klop", # 20th | ||
| "François van 't Sant", # 20th |
There was a problem hiding this comment.
That should be a unicode string.
…ries for buildings. Replaced the Great Spies named after BtS playtesters with Great Spies from etiennefd's list here: dguenms/Dawn-of-Civilization#199 [advc.005b] PerfectMongoose: * Added some code that encourages at least one starting plot per continent to be placed inland. The original script almost never produces inland starts. [advc.021b] * Use AI_foundValue for preselecting starting plots (instead of the much simpler custom "PotentialValue" function). [advc.021b]
…ries for buildings. Replaced the Great Spies named after BtS playtesters with Great Spies from etiennefd's list here: dguenms/Dawn-of-Civilization#199 [advc.005b] PerfectMongoose: * Added some code that encourages at least one starting plot per continent to be placed inland. The original script almost never produces inland starts. [advc.021b] * Use AI_foundValue for preselecting starting plots (instead of the much simpler custom "PotentialValue" function). [advc.021b]
Highlights:
Special focus on China, India, Persia, Ethiopia, England
Merged Persia and Iran
Great Spies
The following civs have received a fairly extensive Spy list (at least 6 names): India, Japan, Vikings, Spain, France, England, Germany, Russia, Poland, Italy, USA.
The following civs have received 1-5 Spy names: China, Korea, Arabia, Portugal, Mughals, Turkey, Netherlands, Argentina, Mexico, Canada
The other civs have no Great Spies, either because I couldn't find any or because they're too unlikely to produce Great Spies in game (e.g. they're too early).