Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 24: #25

Merged
merged 3 commits into from
Nov 13, 2015
Merged

Issue 24: #25

merged 3 commits into from
Nov 13, 2015

Conversation

AJRepo
Copy link
Collaborator

@AJRepo AJRepo commented Oct 30, 2015

This update clarifies that consolidation is for running domains only. Changes:

  • If only one domain is specified, the script errs out and states that consolidating requires running domains.
  • If "all" domains is specified and consolidation is also specified then the running ones are consolidated and the offline ones are backed up normally with an error message generated warning the user of this behavior.
  • Shut-off domain backups also require the -b (backup directory) flag to be set. This prevents accidental backing up to the "/" directory. If "all" domains are specified without the -b flag set, the shut-off domains are skipped.

Afan Ottenheimer added 3 commits October 30, 2015 05:44
Issue #24: Clarify consolidation is for running domains
25f324a 
If the -c flag is specified, backup will continue but
warn that offline backup will backup the entire chain.
Issue #24: Add error messages for -c without -b
12f067a 
Consoliation only works with running or paused domains
This puts out error messages that clarify if you specify
-c for a domain that is shut-off, that it will skip this
domain. Also requires -b flag for backing up shut-off domains
so that you don't back up to root "/"
Typo fix
fddc0de
@AJRepo AJRepo mentioned this pull request Oct 30, 2015
Closed
dguerri added a commit that referenced this pull request Nov 13, 2015
@dguerri
Merge pull request #25 from AJRepo/master
da42184 
Issue 24:
@dguerri dguerri merged commit da42184 into dguerri:master Nov 13, 2015
@dguerri
Copy link
Owner

dguerri commented Nov 13, 2015

Thanks!

@AJRepo AJRepo mentioned this pull request Nov 13, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AJRepo @dguerri