Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update API to use panda-client v1.4.82 pandaclient API #58

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Aug 18, 2021

Resolves #57 . pandatools is renamed to pandaclient.

This will need a patch release to handle the API changes of the underlying tool.

* Adopt panda-client v1.4.82 `pandaclient` API
   - c.f. https://github.com/PanDAWMS/panda-client/commit/eee3914e78347a427ae80a2588d181a6b8632dfb

@matthewfeickert matthewfeickert changed the title fix: Update to latest panda-client API fix: Update API to use panda-client v1.4.82 pandaclient API Aug 18, 2021
Copy link
Collaborator

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kratsg. I'll let @dguest give final review.

@dguest dguest merged commit 92c8f28 into dguest:master Aug 18, 2021
@dguest
Copy link
Owner

dguest commented Aug 18, 2021

Thanks!

dguest pushed a commit that referenced this pull request Oct 20, 2021
* Set lower bound on panda-client to v1.4.82 to ensure `pandaclient` API exists
   - c.f. https://github.com/PanDAWMS/panda-client/releases/tag/1.4.82
   - Amends PR #58
* Add Python 3.9 to Black target-versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panda-client renamed pandatools to pandaclient
3 participants