added missing fields from the submissions page #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgunning
approved these changes
Feb 11, 2024
|
could also convert all those dict calls to .get() then it wouldnt matter
…On Sun, Feb 11, 2024 at 3:15 PM Dwight Gunning ***@***.***> wrote:
***@***.**** approved this pull request.
Seems okay. Will do some testing especially on none-company Entities just
in case some of those fields are Optional
—
Reply to this email directly, view it on GitHub
<#30 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH5ZZ3HSPMISBTRSPGBHGLYTERGVAVCNFSM6AAAAABDDBATLSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZUGQZDOMRYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Accepted. Will perform additional tests. Thanks |
|
Ran batch tests on around 700 person entities and it seems fine as is.
Thanks
Dwight
… On Feb 11, 2024, at 3:18 PM, Rick Albright ***@***.***> wrote:
could also convert all those dict calls to .get() then it wouldnt matter
On Sun, Feb 11, 2024 at 3:15 PM Dwight Gunning ***@***.***>
wrote:
> ***@***.**** approved this pull request.
>
> Seems okay. Will do some testing especially on none-company Entities just
> in case some of those fields are Optional
>
> —
> Reply to this email directly, view it on GitHub
> <#30 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAH5ZZ3HSPMISBTRSPGBHGLYTERGVAVCNFSM6AAAAABDDBATLSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZUGQZDOMRYGE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub <#30 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALT4RYGXVQNAOTR346QYGTYTERQJAVCNFSM6AAAAABDDBATLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXHA2TQMZQHE>.
You are receiving this because you commented.
|
dgunning
added a commit
that referenced
this pull request
Feb 12, 2024
Merge PR (added missing fields from the submissions page #30)
|
Released 2.8.3 with this PR.
Thanks
… On Feb 11, 2024, at 3:53 PM, Dwight Gunning ***@***.***> wrote:
Ran batch tests on around 700 person entities and it seems fine as is.
Thanks
Dwight
> On Feb 11, 2024, at 3:18 PM, Rick Albright ***@***.***> wrote:
>
>
> could also convert all those dict calls to .get() then it wouldnt matter
>
> On Sun, Feb 11, 2024 at 3:15 PM Dwight Gunning ***@***.***>
> wrote:
>
> > ***@***.**** approved this pull request.
> >
> > Seems okay. Will do some testing especially on none-company Entities just
> > in case some of those fields are Optional
> >
> > —
> > Reply to this email directly, view it on GitHub
> > <#30 (review)>,
> > or unsubscribe
> > <https://github.com/notifications/unsubscribe-auth/AAH5ZZ3HSPMISBTRSPGBHGLYTERGVAVCNFSM6AAAAABDDBATLSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZUGQZDOMRYGE>
> > .
> > You are receiving this because you authored the thread.Message ID:
> > ***@***.***>
> >
> —
> Reply to this email directly, view it on GitHub <#30 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALT4RYGXVQNAOTR346QYGTYTERQJAVCNFSM6AAAAABDDBATLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXHA2TQMZQHE>.
> You are receiving this because you commented.
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was just starting to play around with the raw rest api in a personal project when i came across this awesome project. I am making the attempt to modernize the dead github openedgar project. I plan on replacing all the broken api calls using your project, i'll send you updates if you don't mind as i find things missing. i sent you a linkedin invite too, thanks.