Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oracle cloud provider #1

Closed
dgzlopes opened this issue Oct 1, 2020 · 6 comments
Closed

Add Oracle cloud provider #1

dgzlopes opened this issue Oct 1, 2020 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@dgzlopes
Copy link
Owner

dgzlopes commented Oct 1, 2020

Determine if the host cloud provider is Oracle.

You can see how we detect the other providers (e.g AWS) here.

For reference, you can check banzaicloud/satellite code.

@dgzlopes dgzlopes added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 1, 2020
@dennis-pg
Copy link
Contributor

Would like to look into this

@dgzlopes
Copy link
Owner Author

dgzlopes commented Oct 1, 2020

Hi @dennis-pg! Thanks for your interest. Feel free to ping me if you need help.

@dennis-pg
Copy link
Contributor

Hi @dgzlopes

The file-based method looks okay. The metadata server based method does not seem to be working as per banzaicloud/satellite code The link -> http://169.254.169.254/opc/v1/instance/metadata/ only contains an ssh key as mentioned in the docs

Do you want to use some other logic to determice if its is OCI from the response?

@dgzlopes
Copy link
Owner Author

dgzlopes commented Oct 1, 2020

Um, yeah, it only contains a list of ssh keys 😐

I'm not sure why Satellite is doing that, and well, I don't have experience with Oracle Cloud... So I would say, that for now, we can implement the file-based method - and it should work as expected.

We can leave the metadata approach for another issue. Might involve creating an Oracle account, spawning instances, testing things...

I kinda prefer unknowns that bad results 😜

@dgzlopes
Copy link
Owner Author

dgzlopes commented Oct 1, 2020

But probably some SSH key contains the string that Satellite checks (e.g Scaleway makes something similar) - that's something we should research.

@dennis-pg
Copy link
Contributor

Have raised PR

@dgzlopes dgzlopes closed this as completed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants