Add Oracle cloud provider #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dennis-pg
commented
Oct 3, 2020
dennis-pg
commented
- Oracle Cloud Infrastructure detection added
- The metadata server method used by satellite does not seem consistent, so have kept that as un-implemented for now.
- OCI uses a similar metadata server address to Azure, and since the Azure metadata check relied on the code to throw an error while hitting the endpoint, it introduced issues in OCI instances. Here, it returned a 404 but did not throw an error. As a result OCI instances were (and still are for current versions of cloud_detect) being detected as Azure instances. So have added code to check response status in the Azure Provider.
Signed-off-by: Dennis P George <dennisgeorge.mec@gmail.com>
Signed-off-by: Dennis P George <dennisgeorge.mec@gmail.com>
Signed-off-by: Dennis P George <dennisgeorge.mec@gmail.com>
Closed
|
Failing test is due to the issue mentioned for python 3.4 for tox which will be removed following the move to Github actions PR. Else seems fine @dgzlopes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.