Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dhall-repl does not include version information #411

Closed
quasicomputational opened this issue May 28, 2018 · 2 comments
Closed

dhall-repl does not include version information #411

quasicomputational opened this issue May 28, 2018 · 2 comments

Comments

@quasicomputational
Copy link
Collaborator

dhall-repl does not recognise --version and, upon startup, it does not output its version number. This makes it difficult to know which version of Dhall you are running, and specifically whether you are on an old version of Dhall; since dhall-repl is the most convenient way to demonstrate short Dhall examples, this makes reporting bugs more annoying than it should be.
@Gabriella439
Copy link
Collaborator

@quasicomputational: I was thinking of moving all of the dhall-* commands in this package as subcommans of the dhall executable. So in other words, instead of dhall-repl you would use dhall repl. If I did that then you would get --version for free since there is also a dhall version subcommand of the same executable.

Would that solve your problem?

@quasicomputational
Copy link
Collaborator Author

Sounds good to me!

Gabriella439 added a commit that referenced this issue Jun 7, 2018
@Gabriella439
Change dhall-repl to dhall repl
a5ca33e 
Fixes #411

This moves `dhall-repl` to become a `repl` subcommand of the `dhall`
executable for command-line consistency

This also extends the REPL logic to respect the command-line `--explain` flag
@Gabriella439 Gabriella439 mentioned this issue Jun 7, 2018
Merged
Gabriella439 added a commit that referenced this issue Jun 8, 2018
@Gabriella439
Change dhall-repl to dhall repl (#435)
f1cc31b 
Fixes #411

This moves `dhall-repl` to become a `repl` subcommand of the `dhall`
executable for command-line consistency

This also extends the REPL logic to respect the command-line `--explain` flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gabriella439 @quasicomputational