Remove duplicated tests between dhall-lang and dhall-haskell

[jneira]

Wouldn't be desirable avoid the duplication between spec tests in this repo and the dhall-lang ones?
Modifications could be:

• Remove spec tests from dhall-haskell
• Include dhall-lang as submodule of dhall-haskell (like dhall-clj)
• Read spec tests cases from there and the implementation specific ones from the actual location
• Set up some way to skip spec tests explicitly in case we want to ship a dhall-haskell version not 100% compliant

[Gabriella439]

@jneira: The main limitation here is that I haven't figured out how to get Hydra to work with git submodules. If somebody can get it working I'd accept the change

[jneira]

Mmm another way could be parametrize the spec tests location and set by default to ../dhall-lang/tests, but it implies make two steps to run the tests. If Hydra is able to checkout other repos, it should work.
That is my setup to run dhall-eta tests: https://github.com/eta-lang/dhall-eta/blob/master/.circleci/config.yml#L47

We should document the steps and print an error in case the tests suite is executed without spec tests in the selected location.

[ocharles]

We use submodules extensively at work, I'll share our patches.

…

On Sun, 30 Dec 2018, 3:29 pm Javier Neira ***@***.*** wrote: Mmm another way could be parametrize the spec tests location and set by default to ../dhall-lang/tests, but it implies make two steps to run the tests. If Hydra is able to checkout other reports, it should work. That is my setup to run dhall-eta tests: https://github.com/eta-lang/dhall-eta/blob/master/.circleci/config.yml#L47 We should document the steps and print an error in case the tests suite is executed without spec tests in the selected location. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#766 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABRjikWVvcn5nvtV35-dqRo91_21jSAks5u-NvFgaJpZM4Zj2SM> .

[ocharles]

It turns out there are no patches needed. Here's our hydra.nix Nixpkgs overlay:

self: super:
{ hydra =
    super.hydra.overrideAttrs
      ( _:
        { src =
            self.fetchFromGitHub
              { owner = "NixOS";
                repo = "hydra";
                rev = "63a294d4caa1124dd1c7d08c06ccef4113154bc8";
                sha256 = "0xw6kph7zxlq2inb4aglp8g0hinnyz8z4x2dmkjnc2lhkhsdaq1j";
              };

          patches =
            [ # Fix for https://github.com/NixOS/nix/issues/1888
              ./hydra/unrestrict-hydra.diff

              ./hydra/job-name.patch

              ./hydra/hydra-auth-file.patch

              ./hydra/faster-clone.patch
            ];

          doCheck =
            false;
        }
      );
}

None of those patches change submodule behaviour.

[f-f]

@ocharles @Gabriel439 any further ideas on this? Could it be this issue?

[ocharles]

I would like to know if using the above version of Hydra works. Without knowing the version that doesn't work it's hard to give more advice.

[Gabriella439]

@ocharles: Yeah, I need to pin Dhall CI to a specific revision of Nixpkgs. The Nixpkgs revision I've mostly recently deployed from is:

• NixOS/nixpkgs@d56ec49

... which corresponds to this revision of Hydra:

• NixOS/hydra@4dca8fe

... which is a couple of months older than the revision you are using:

• NixOS/hydra@63a294d

Here is the difference between the two revision:

NixOS/hydra@4dca8fe...63a294d

From a brief scan of that, it looks like this submodule-related commit might fix things: NixOS/hydra@8bffbb7

I'll try to see if deploying that newer revision of Hydra fixes things

[Gabriella439]

Looks like submodules are back on the menu: #787

[jneira]

Hi, @Gabriel439 test code should be updated to read the tests from the new locations. Should we open a new one about?

[Gabriella439]

@jneira: I did update the test code to read the test files from the new location