-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dhall-json: yaml-pre-0_11 does not build #969
Comments
Ah, that's annoying. It's been broken for a while, then: in #962, I tried to bump it to 0.11 across the board, but bounds rule it out on GHC 7.10. And 0.10.2.0 similarly requires GHC 8.0. |
@singpolyma: Do you need |
Mmm, if |
nvm, we dropped support for |
@singpolyma: Do you need `dhall-json` to build for `yaml` versions earlier than `0.10.20`
Yes. I am maintaining a small local patch for now that allows me to build it -- but it's not a "correct" patch since I just replace calls to encodeWith with calls to encode and ignore the options.
|
@singpolyma: Note that the change I'm going to make is going to do the same thing (ignore the options for older versions of |
Fix is up here: #981 |
Says it allows all the way down to yaml 0.5.0, but relies on features introduced in yaml 0.10.2.0 without CPP guards (namely,
encodeWith
and encoding options)The text was updated successfully, but these errors were encountered: