Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhall-json: yaml-pre-0_11 does not build #969

Closed
singpolyma opened this issue May 25, 2019 · 7 comments · Fixed by #981
Closed

dhall-json: yaml-pre-0_11 does not build #969

singpolyma opened this issue May 25, 2019 · 7 comments · Fixed by #981

Comments

@singpolyma
Copy link
Contributor

Says it allows all the way down to yaml 0.5.0, but relies on features introduced in yaml 0.10.2.0 without CPP guards (namely, encodeWith and encoding options)

@singpolyma singpolyma changed the title yaml-pre-0_11 does not build dhall-json: yaml-pre-0_11 does not build May 25, 2019
@quasicomputational
Copy link
Collaborator

Ah, that's annoying. It's been broken for a while, then: in #962, I tried to bump it to 0.11 across the board, but bounds rule it out on GHC 7.10. And 0.10.2.0 similarly requires GHC 8.0.

@Gabriella439
Copy link
Collaborator

@singpolyma: Do you need dhall-json to build for yaml versions earlier than 0.10.20 or would revising the lower bound to be 0.10.20.0 be an acceptable solution?

@jneira
Copy link
Collaborator

jneira commented May 28, 2019

Mmm, if yaml-0.10.20.0 doesnt work with ghc-7.10.3, we'll have to remove dhall-json from the appveyor build.
Strangely, the appveyor build for the pr succeded for ghc-7.10.3, using yaml-0.8.21.1. 🤔

@jneira
Copy link
Collaborator

jneira commented May 28, 2019

nvm, we dropped support for dhall-json with ghc-7.10.3 in #941 (it introduced encodeWith too). So bump up lower bound to 0.10.20.0 would be fine.

@singpolyma
Copy link
Contributor Author

singpolyma commented May 28, 2019 via email

@Gabriella439
Copy link
Collaborator

@singpolyma: Note that the change I'm going to make is going to do the same thing (ignore the options for older versions of yaml), because as far as I know specifying the quoting for multi-line literals is not supported at all by older yaml versions. However, that's the only thing it affects and in the worst case scenario it will just generate a weirdly formatted but still valid string literal.

Gabriella439 added a commit that referenced this issue Jun 1, 2019
@Gabriella439
Copy link
Collaborator

Fix is up here: #981

Gabriella439 added a commit that referenced this issue Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants