Add dhall-json support for weakly-typed JSON values
#1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dhall-lang/dhall-lang#409 This matches the standard representation for arbitrary JSON proposed in dhall-lang/dhall-lang#586
This was referenced Jun 13, 2019
Closed
ocharles
reviewed
Jun 20, 2019
| > let JSON = https://prelude.dhall-lang.org/JSON/package.dhall | ||
| > | ||
| > in JSON.object | ||
| > [ { mapKey = "foo", mapValue = JSON.null } |
There was a problem hiding this comment.
This ship has probably sailed now, but it's a little strange to me that we call it an object in the constructor, but the elements talk about a map. object with propertyKey/propertyValue might have been better, as objects have properties, rather than maps (they are maps).
There was a problem hiding this comment.
@ocharles: The names for the constructors are based on the official grammar for JSON: https://www.json.org/
There was a problem hiding this comment.
Sorry, I misunderstood your comment. The reason for still using mapKey/mapValue is so that once we support the toMap keyword, we can do this:
let JSON = https://prelude.dhall-lang.org/JSON/package.dhall
in JSON.object (toMap { foo = JSON.number 1, bar = JSON.number 2 })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dhall-lang/dhall-lang#409
This matches the standard representation for arbitrary JSON proposed in
dhall-lang/dhall-lang#586
This change supports conversions in both directions (from
JSON/TypetoJSON and back)