Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Sort as type annotation #1024

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Allow Sort as type annotation #1024

merged 2 commits into from
Jun 27, 2019

Conversation

sjakobi
Copy link
Collaborator

@sjakobi sjakobi commented Jun 26, 2019

Standardized in dhall-lang/dhall-lang#507.

sjakobi
sjakobi commented Jun 26, 2019
View reviewed changes
dhall/src/Dhall/TypeCheck.hs Outdated Show resolved Hide resolved
@sjakobi sjakobi mentioned this pull request Jun 27, 2019
Merged
Gabriella439
Gabriella439 approved these changes Jun 27, 2019
View reviewed changes
dhall/src/Dhall/TypeCheck.hs Outdated Show resolved Hide resolved
@sjakobi
Copy link
Collaborator Author

sjakobi commented Jun 27, 2019

Thanks for the commit bits @Gabriel439! :)

Given your approval, can I just merge once CI has passed?

@Gabriella439
Copy link
Collaborator

@sjakobi: Yeah, you can merge at any time once you have an approval

@sjakobi sjakobi merged commit 634f1f3 into dhall-lang:master Jun 27, 2019
@sjakobi sjakobi deleted the sort-annotation branch June 27, 2019 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriella439 Gabriella439 Gabriella439 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sjakobi @Gabriella439