Switch Var to use an Int
#1044
Merged
Switch Var to use an Int
#1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to: #1039 We'll probably never see indices that exceed the space of an `Int` and the interpreter would probably not be able to handle 9223372036854775807 nested binders anyway.
ocharles
reviewed
Jul 1, 2019
| @@ -336,7 +336,7 @@ instance Pretty Import where | |||
| Zero indices are omitted when pretty-printing `Var`s and non-zero indices | |||
| appear as a numeric suffix. | |||
| -} | |||
| data Var = V Text !Integer | |||
| data Var = V Text !Int | |||
There was a problem hiding this comment.
Maybe go all the way and {-# UNPACK #-}? It's already strict.
There was a problem hiding this comment.
Actually, I think GHC already unpacks these strict fields now.
There was a problem hiding this comment.
Yeah, I believe GHC will automatically unbox strict fields if they are no larger than a pointer.
Note that I haven't actually benchmarked this; I'm only forward-porting small chunks of the work mentioned in #1039
sjakobi
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #1039
We'll probably never see indices that exceed the space of an
Intandthe interpreter would probably not be able to handle 9223372036854775807
nested binders anyway.