Dhall.Eval.eqMapsBy: Compare map sizes before contents #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe |
|
Also, it's fine if we move the logic into |
Ah, I'll hold off until we need the same function in a different module. |
Data.Map.size is O(1), so we expose it via Dhall.Map.
sjakobi
force-pushed
the
sjakobi/eq-maps-by
branch
from
438d1cb
to
fb6fc6e
Compare
|
The Mergify check doesn't even show up now. Maybe because the config is different on this branch?! I'll update the branch to see if that fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data.Map.size is O(1), so we expose that via Dhall.Map.