Sort the fields of record projection during normalization #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabriella439
approved these changes
Jul 15, 2019
| @@ -66,3 +67,6 @@ empty = Set Data.Set.empty Data.Sequence.empty | |||
| difference :: Ord a => Set a -> Set a -> [a] | |||
| difference os (Set s _) = | |||
| filter (\ x -> not (Data.Set.member x s)) (toList os) | |||
|
|
|||
| sort :: Ord a => Set a -> Set a | |||
There was a problem hiding this comment.
Could you add a haddock comment since it's part of the public API?
…as standardized in dhall-lang/dhall-lang#625.
sjakobi
force-pushed
the
sjakobi/sort-projection-fields
branch
from
a29fce8
to
87425c6
Compare
|
I also tried to fix Did you ever take a stab at the property tests you mention in #522 (comment), @Gabriel439? |
|
@sjakobi: I did, but they were disabled as part of the work on Also: #876 (comment) |
|
@Gabriel439 Thanks for the pointers! I'll try to bring these tests back. |
|
@sjakobi: You're welcome! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…as standardized in dhall-lang/dhall-lang#625.