Remove Dhall.X and replace with Data.Void #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the Dhall.X module and the Dhall.X.X type, preferring the use of Data.Void.Void. As I'm sure a lot of people are actually using X, I've added a type-alias type X = Void. However, pattern matching on X would be a breaking change. Fixes dhall-lang#1120.
f-f
reviewed
Jul 30, 2019
Gabriella439
approved these changes
Aug 1, 2019
sjakobi
reviewed
Aug 5, 2019
| @@ -52,6 +52,8 @@ import qualified Dhall.Set | |||
| import qualified Dhall.Pretty.Internal | |||
| import qualified Dhall.Util | |||
|
|
|||
| type X = Void | |||
There was a problem hiding this comment.
A bit of documentation for why we have this type alias would be good.
Also: Do we want to keep it forever, or are we going to deprecate it?
There was a problem hiding this comment.
@sjakobi: We'll eventually deprecate it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the Dhall.X module and the Dhall.X.X type,
preferring the use of Data.Void.Void. As I'm sure a lot of people are
actually using X, I've added a type-alias type X = Void. However,
pattern matching on X would be a breaking change.
Fixes #1120