dhall-json: Nesting: Support empty alternatives as contents #1204
Conversation
| alternativeName | ||
| ) | ||
| contents | ||
| , contents | ||
| ) | ||
| , ( "field" |
There was a problem hiding this comment.
The additional indentation here confused me for so long, I ended up opening a GHC issue! ;)
There was a problem hiding this comment.
Yeah, the indentation there bugged me, too 🙂
| ) | ||
| contents | ||
| ] | isInlineNesting nesting | ||
| , Just (alternativeName, Just (Core.RecordLit kvs)) <- getContents contents -> do |
There was a problem hiding this comment.
I wonder whether we should report an error in this case:
| , Just (alternativeName, Just (Core.RecordLit kvs)) <- getContents contents -> do | |
| , Just (alternativeName, Just notARecordLit) <- getContents contents -> do |
Non-record alternatives are supported with Nested, so users might also try them with Inline.
There was a problem hiding this comment.
@sjakobi: Yeah, we probably should report an error here. It's up to you if you want to include that in this pull request or not
There was a problem hiding this comment.
I'll add the error in a follow-up PR.
| alternativeName | ||
| ) | ||
| contents | ||
| , contents | ||
| ) | ||
| , ( "field" |
There was a problem hiding this comment.
Yeah, the indentation there bugged me, too 🙂
| ) | ||
| contents | ||
| ] | isInlineNesting nesting | ||
| , Just (alternativeName, Just (Core.RecordLit kvs)) <- getContents contents -> do |
There was a problem hiding this comment.
@sjakobi: Yeah, we probably should report an error here. It's up to you if you want to include that in this pull request or not
|
Thank you! |
Closes #1201.