Small fixes to dhall diff
#1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #1255 * Simplify function type diffs by omitting the bound variable name when possible * Non-zero exit code when `dhall diff` is non-empty Note that this is a breaking change to the `Dhall.Diff` API by changing the exposed utilities to all expose the more general `Diff` type instead of a `Doc`. This means that we also no longer need separate exports for `diff` and `diffExpression`.
sjakobi
reviewed
Aug 31, 2019
There was a problem hiding this comment.
- Simplify function type diffs by omitting the bound variable name when possible
- Simplify diffs of bound variables when possible
The appList test case seems to cover the second change. Would you mind also adding a test for the first one? My current general impression is that we have very low test coverage for some fairly tricky code here.
dhall/src/Dhall/Diff.hs
Outdated
| where | ||
| Diff {..} = diffExpression l0 r0 | ||
| diff :: (Eq a, Pretty a) => Expr Void a -> Expr Void a -> Diff | ||
| diff = diffExpression |
There was a problem hiding this comment.
How about renaming diffExpression to diff?
... as suggested by @sjakobi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1255
dhall diffis non-emptyNote that this is a breaking change to the
Dhall.DiffAPI by changing theexposed utilities to all expose the more general
Difftype instead of aDoc. This means that we also no longer need separate exports fordiffanddiffExpression.