Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dhall version #1332

Merged
merged 6 commits into from
Sep 20, 2019
Merged

Dhall version #1332

merged 6 commits into from
Sep 20, 2019

Conversation

vmchale
Copy link
Collaborator

@vmchale vmchale commented Sep 20, 2019

This adds an exposed module Dhall.Version, which I can use downstream.

I also used it internally.

@vmchale vmchale merged commit fe748e2 into dhall-lang:master Sep 20, 2019
@vmchale vmchale deleted the dhall-version branch September 20, 2019 15:56
@@ -0,0 +1,12 @@
module Dhall.Version ( dhallVersion
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to document, that this module is about the version of the dhall library, not about the version of the Dhall standard.

@@ -510,6 +511,8 @@ Library
Dhall.Import.Types,
Dhall.Eval,
Paths_dhall
Autogen-Modules:
Paths_dhall
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmchale Would you mind explaining why you added this Autogen-Modules section? This might be relevant for my patch for #1331.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants