Update reservedIdentifiers #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `missing` and `assert` * Reformat them to match the grammar
sjakobi
commented
Oct 24, 2019
dhall/src/Dhall/Syntax.hs
Outdated
| , "Sort" | ||
|
|
||
| -- Technically just an `operator` | ||
| , "forall" |
There was a problem hiding this comment.
Not sure whether forall should be added to the keyword rule.
There was a problem hiding this comment.
Yeah, I would have expected to see forall in the keyword section of the standard grammar (even for the Unicode version: ∀), rather than the operator section. Maybe the standard needs to be fixed
There was a problem hiding this comment.
Maybe the standard needs to be fixed
Gabriella439
approved these changes
Oct 25, 2019
dhall/src/Dhall/Syntax.hs
Outdated
| , "Sort" | ||
|
|
||
| -- Technically just an `operator` | ||
| , "forall" |
There was a problem hiding this comment.
Yeah, I would have expected to see forall in the keyword section of the standard grammar (even for the Unicode version: ∀), rather than the operator section. Maybe the standard needs to be fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missingandassert