Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dhall-to-yaml to quote special strings #1474

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Fix dhall-to-yaml to quote special strings #1474

merged 2 commits into from
Oct 25, 2019

Conversation

Gabriella439
Copy link
Collaborator

Fixes #1472

This also refactors the code to a form that was easier for me to understand

@Gabriella439
Fix dhall-to-yaml to quote special strings
309949f 
Fixes #1472

This also refactors the code to a form that was easier for me to understand
@Gabriella439 Gabriella439 mentioned this pull request Oct 25, 2019
Closed
sjakobi
sjakobi approved these changes Oct 25, 2019
View reviewed changes
Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a great simplification! 👍

What I haven't understood so far is in what way * is special in YAML or in some YAML implementations. Would anyone care to explain? :)

@amarrella
Copy link

@sjakobi: the best info that I found is that the parser treats it as an alias indicator: https://yaml.org/refcard.html

@Gabriella439 Gabriella439 merged commit 8e7586b into master Oct 25, 2019
@Gabriella439 Gabriella439 deleted the gabriel/1472 branch October 25, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should dhall-to-yaml quote special strings?
3 participants
@Gabriella439 @amarrella @sjakobi