Don't include context in default output #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation for this is so that `dhall` can be made much faster on very large projects like `dhall-kubernetes-charts` where vast majority of the time is spent rendering the very large `Context` when type-checking fails, delaying the user from getting to the actual error message. The `Context` also gets in the way of the user noticing the (far more useful) type diff, but the performance cost is the primary motivation for this change. If the user wants the context they can still use the `--explain` flag.
sjakobi
approved these changes
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this is so that
dhallcan be made much faster on verylarge projects like
dhall-kubernetes-chartswhere vast majority of the timeis spent rendering the very large
Contextwhen type-checking fails, delayingthe user from getting to the actual error message.
The
Contextalso gets in the way of the user noticing the (far more useful)type diff, but the performance cost is the primary motivation for this change.
If the user wants the context they can still use the
--explainflag.