Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integer/{clamp,negate} built-ins #1486

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

Gabriella439
Copy link
Collaborator

... as standardized in dhall-lang/dhall-lang#780

Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

let e0 = Fix (NConstant (NInt 0))
let e1 = Fix (NBinary NLte (Fix (NConstant (NInt 0))) "x")
let e2 = Fix (NAbs "x" (Fix (NIf e1 "x" e0)))
return e2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fairly hard to review. I wonder whether we should invest in a proper test setup here…

@sjakobi sjakobi added merge me and removed merge me labels Oct 29, 2019
@mergify mergify bot merged commit 1349a50 into master Oct 29, 2019
@mergify mergify bot deleted the gabriel/integer_negate_and_clamp branch October 29, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants