Add --check flag to dhall {lint,freeze}
#1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sjakobi
reviewed
Jan 19, 2020
There was a problem hiding this comment.
I was briefly confused about the PR title. I think you meant {lint,freeze}.
I really like that format, freeze and lint have such a uniform API now! :)
I think it's a bit awkward that to check a file, you have to write e.g. dhall freeze --check --inplace x.dhall – --inplace doesn't really make sense in this combination. I don't see an easy way to resolve that though.
|
Yeah, I mean |
sjakobi
changed the title
--check flag to dhall {lint,format}--check flag to dhall {lint,freeze}
sjakobi
approved these changes
Jan 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1629
The main changes here are:
FormatModefrom (conceptually)Either FilePath FilePathto(Bool, FilePath)FormatModeandNotFormattedto be usable for linting and freezing, too--checkfails (which was previously blank)