Drop support for GHC 7.10.3 #1649
Conversation
The immediate motivation for doing this is so that we don't need to introduce yet another GHC 7.10.3 workaround for #1640 More generally, the main reason we were still supporting GHC 7.10.3 was for Eta compatibility, but Eta appears to no longer be actively developed. Given that Eta seems unlikely to support GHC 8 and we don't plan on supporting GHC 7.10.3 in perpetuity it's probably time to drop support. We could probably drop support for additional GHC versions, but this is just the smallest change necessary to unblock #1640.
There was a problem hiding this comment.
We can get rid of some CPP conditionals for base, directory and template-haskell with this change. I can do that in a follow-up PR!
We should also raise the lower bound on base, but maybe that should happen in #1640 instead.
@jneira Do you plan on continuing to contribute if we stop supporting 7.10 and thereby Eta? Particularly your Windows expertise was very valuable!
|
I've been waiting to see a specific change that needed or was easier to implement droping support for ghc-7.10.3 to advise to do it so i totally agree on this (i missed #1640 was blocked on that). @sjakobi well, i really like dhall and that was the reason to try keep it buildable with eta and use it as the main config format for etlas so my intent is to keep contributing. You are doing a great job so the project is going forward at a good pace. Otoh, i am lately more involved in the haskell ide ecosystem but i continue keeping an eye on dhall 😉 |
|
Thinking twice there are one caveat: i used eta to make the java language binding. Keeping it in sync could take more effort cause we should patch dhall to make it buildable with eta via eta-hackage. |
|
@jneira I do use the dhall libraries with Eta, but agree with @Gabriel439 that it's not sustainable to directly support 7.10.3 forever. Somebody else maintaining Eta patches for later versions seems good! I'm too time-constrained right now, but I might take that on Later(TM). |
... as suggested by @sjakobi
... which is GHC 7.10.3 We should probably add a `stack-lts-*.yml` for GHC 8, but I'll leave that to another contributor since I do not use `stack`
The immediate motivation for doing this is so that we don't need to
introduce yet another GHC 7.10.3 workaround for
#1640
More generally, the main reason we were still supporting GHC 7.10.3
was for Eta compatibility, but Eta appears to no longer be actively
developed. Given that Eta seems unlikely to support GHC 8 and we
don't plan on supporting GHC 7.10.3 in perpetuity it's probably
time to drop support.
We could probably drop support for additional GHC versions, but this
is just the smallest change necessary to unblock #1640.