-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dhall.Deriving module for deriving-via helpers #1700
Conversation
Could you add the new module to |
Hi @sjakobi, I tried adding the
I tried building with stack too, but Finally, Whew. I think I've exhausted my options here, so I'd really appreciate your help, if possible. Thanks! |
Well, while working doctests are totally neat, the setup and ergonomics do leave a lot to be desired! :/ I always use --- a/dhall/doctest/Main.hs
+++ b/dhall/doctest/Main.hs
@@ -38,6 +38,7 @@ main = do
-- , prefix </> "src"
, "-i" <> (prefix </> "src")
+ , prefix </> "src/Dhall/Deriving.hs"
, prefix </> "src/Dhall/Tags.hs"
, prefix </> "src/Dhall/Tutorial.hs"
] …gives me:
I use Ubuntu BTW. With You may want to try some of the workarounds described there. Also, l think most people eventually managed to get the doctests working with
Regarding GHC compatibility: The first thing to try would be to move the problematic doctests behind CPP. I usually refer to https://guide.aelve.com/haskell/cpp-vww0qd72#item-fkuvztqe for that. If that doesn't work out (I'm not sure how well This is all a bit annoying and tricky, so please do let me know in case you get stuck! :) |
d928d34
to
3c8bbf4
Compare
Hey again @sjakobi! Thanks for your tips! Eventually I got |
I'm glad you got it working! :) I haven't yet reviewed |
Gladly! |
Hi again @sjakobi, is there anything I need to do to get the hydra check to run? |
Hydra does run (and fail), but the GitHub interface doesn't show it. It would be great if we could get that fixed properly! :/ For now you can find the Hydra results for this PR at https://hydra.dhall-lang.org/jobset/dhall-haskell/1700. |
I see! Thanks! |
8677872
to
16d8a98
Compare
Finally got it to build! Is it okay if I merge it? |
Well done! Sorry for the delay with my review! I'll try to get it done until tomorrow evening at the latest. |
Oh don’t worry at all. Thanks for the help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry again for the late review! This machinery looks super slick! 👍
Nevertheless I have a few comments! ;)
Co-Authored-By: Simon Jakobi <simon.jakobi@gmail.com>
Co-Authored-By: Simon Jakobi <simon.jakobi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers! :)
I've been working on adapting @parsonsmatt's blog post on reflection and encoding via applied to Aeson to work on Dhall. I'm happy with my current implementation, though I'd still like to add a few tests and possibly improve documentation with a guide or something similar. I'd also like to gather some feedback before merging.