-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for record puns #1710
Conversation
... as standardized in dhall-lang/dhall-lang#938
I've pushed a patch that should fix |
@@ -182,7 +182,6 @@ Extra-Source-Files: | |||
dhall-lang/tests/import/cache/dhall/1220efc43103e49b56c5bf089db8e0365bbfc455b8a2f0dc6ee5727a3586f85969fd | |||
dhall-lang/tests/import/data/*.dhall | |||
dhall-lang/tests/import/data/*.txt | |||
dhall-lang/tests/import/data/fieldOrder/*.dhall | |||
dhall-lang/tests/import/failure/*.dhall | |||
dhall-lang/tests/import/success/*.dhall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these glob entries wouldn't include test files like tests/import/success/unit/AlternativeChain1A.dhall
. We might be missing a bunch of test cases then, at least when running them with nix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjakobi: Yeah, we are likely missing a bunch of test cases, especially after the refactor. I believe newer versions of Cabal support **
syntax for globbing through nested directories, so then we would be able to write: dhall-lang/tests/**.dhall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the syntax is a bit more complicated and inconvient though: https://cabal.readthedocs.io/en/latest/file-format-changelog.html#cabal-version-2-4
I hope requiring Cabal-2.4 is ok. I think it would make building with Nix and GHC < 8.6 more tricky though.
In any case, I think we should address this issue separately.
Hydra reports two test failures in https://hydra.dhall-lang.org/build/54229/nixlog/5:
|
I'm confused why such tests would live in the type-inference directory… |
51aa536
to
31ff8bc
Compare
My last commit should handle the two
|
I think I might have had some old state in my |
I think the Travis failure with
…is probably safe to ignore. |
@sjakobi: Yeah, I think it was a temporary Travis outage. I'll rerun it |
... as standardized in dhall-lang/dhall-lang#938