Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow template-haskell-2.16 #1719

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Allow template-haskell-2.16 #1719

merged 1 commit into from
Apr 1, 2020

Conversation

sjakobi
Copy link
Collaborator

@sjakobi sjakobi commented Mar 27, 2020

This uses -XDeriveLift to address the missing liftTyped definitions.

@sjakobi sjakobi mentioned this pull request Mar 27, 2020
6 tasks
This uses -XDeriveLift to address the missing liftTyped definitions.
@sjakobi sjakobi changed the title WIP: Allow template-haskell-2.16 Allow template-haskell-2.16 Mar 31, 2020
@sjakobi
Copy link
Collaborator Author

sjakobi commented Mar 31, 2020

At this point, I can already successfully cabal test dhall:tasty dhall-json dhall-yaml with GHC 8.10 if I use this patch to work around bounds issues:

--- a/cabal.project
+++ b/cabal.project
@@ -1 +1,3 @@
-packages: ./dhall ./dhall-bash ./dhall-json ./dhall-yaml ./dhall-lsp-server ./dhall-nix
+packages: ./dhall ./dhall-bash ./dhall-json ./dhall-yaml
+
+allow-newer: serialise:ghc-prim, cborg-json:base, cborg:ghc-prim

@Gabriel439, maybe this would also be worth including in the release! (Not sure if it's still a minor release BTW)

@Gabriella439
Copy link
Collaborator

@sjakobi: Is it a breaking change to the API?

@sjakobi
Copy link
Collaborator Author

sjakobi commented Mar 31, 2020

Is it a breaking change to the API?

I think the type changes in Dhall.Repl in #1717 probably were. Although I don't believe that a lot of library users will notice…

@Gabriella439
Copy link
Collaborator

@sjakobi: Oh yeah. Either way, that's fine. There's no harm in cutting a 1.32.0 release. I don't obsess too much over version numbers if it's necessary to bump them to push out fixes. In my view, the only mistake is not releasing frequently enough (i.e. piling up too many breaking changes in infrequent big bang releases)

@Gabriella439
Copy link
Collaborator

Also, looking at this more closely, I don't think the Dhall.Repl changes are breaking anyway because we don't expose those in the public API. See: https://hackage.haskell.org/package/dhall-1.31.0/docs/Dhall-Repl.html

@sjakobi sjakobi merged commit cb23ca5 into master Apr 1, 2020
@sjakobi sjakobi deleted the sjakobi/ghc-8.10 branch April 1, 2020 00:40
@sjakobi
Copy link
Collaborator Author

sjakobi commented Apr 1, 2020

Also, looking at this more closely, I don't think the Dhall.Repl changes are breaking anyway because we don't expose those in the public API

All the better! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants