Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer to format using record puns when possible #1729

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Conversation

Gabriella439
Copy link
Collaborator

Fixes #1728

Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I sometimes wonder what users think about dhall format "pushing" all the new syntactic sugar into their code bases. I'd suspect that many appreciate it and others don't… ;)

@Gabriella439
Copy link
Collaborator Author

@sjakobi: Yeah, I wouldn't worry too much about it. The people who are picky about how to format their code aren't going to use dhall format anyway. The target audience of dhall format are people who just want to avoid formatting-related disagreements by having one true way to format things, so they'll tolerate an opinionated formatting tool as long as it's not egregiously bad.

@ari-becker
Copy link

+1

I sometimes wonder what users think about dhall format "pushing" all the new syntactic sugar into their code bases. I'd suspect that many appreciate it and others don't… ;)

Anecdotally, we (my team and I) find that it's a really great way to find out how new language features can help improve our codebase.

The stuff that irks us about the auto-formatter isn't when it "pushes syntactic sugar", so to speak, but rather the changes to whitespace formatting that seem to happen every time we upgrade. We're starting to get to about 60,000 lines of Dhall across nearly forty repositories and every time the pretty printer changes, we get hit by enormous changesets adapting the new formatting. Obviously, we still prefer the benefits of the auto-formatter, as opinionated formatting is much more valuable, but we'd like the opinionated auto-formatter to stabilize its opinion ;)

@sjakobi
Copy link
Collaborator

sjakobi commented Mar 30, 2020

Many thanks for the feedback @ari-becker! :)

Also, 60,000 lines sounds like a lot! 😲

@Profpatsch
Copy link
Member

imho the built-in auto-formatter is one of the big pros of dhall over any other configuration language (looking at you nix).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dhall format desugars record puns
4 participants