Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove the speed of file-only imports #194
Conversation
Gabriel439
merged commit 6ff5852
into
master
Dec 21, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Gabriel439
deleted the
gabriel/faster_files
branch
Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Gabriel439 commentedDec 17, 2017
This overhauls
exprFromPath(and every function downstream of that) tospeed up imports when no URLs are imported.
Previously, Dhall would always demand a
Manageron the very firstimport, whether or not Dhall actually needed to fetch a remote URL.
Fetching this
Manageradds an unusually long overhead (~1 s) toprograms that only needed to fetch local files.
Now the
Manageris only requested as late as possible (i.e. rightbefore the first URL import)
This is a breaking change, since it changes the types of several exported
utilities in the API