Improve the speed of file-only imports #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This overhauls `exprFromPath` (and every function downstream of that) to speed up imports when no URLs are imported. Previously, Dhall would always demand a `Manager` on the very first import, whether or not Dhall actually needed to fetch a remote URL. Fetching this `Manager` adds an unusually long overhead (~1 s) to programs that only needed to fetch local files. Now the `Manager` is only requested as late as possible (i.e. right before the first URL import)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overhauls
exprFromPath(and every function downstream of that) tospeed up imports when no URLs are imported.
Previously, Dhall would always demand a
Manageron the very firstimport, whether or not Dhall actually needed to fetch a remote URL.
Fetching this
Manageradds an unusually long overhead (~1 s) toprograms that only needed to fetch local files.
Now the
Manageris only requested as late as possible (i.e. rightbefore the first URL import)
This is a breaking change, since it changes the types of several exported
utilities in the API