New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the speed of file-only imports #194

Merged
merged 1 commit into from Dec 21, 2017

Conversation

Projects
None yet
1 participant
@Gabriel439
Collaborator

Gabriel439 commented Dec 17, 2017

This overhauls exprFromPath (and every function downstream of that) to
speed up imports when no URLs are imported.

Previously, Dhall would always demand a Manager on the very first
import, whether or not Dhall actually needed to fetch a remote URL.
Fetching this Manager adds an unusually long overhead (~1 s) to
programs that only needed to fetch local files.

Now the Manager is only requested as late as possible (i.e. right
before the first URL import)

This is a breaking change, since it changes the types of several exported
utilities in the API

Improve the speed of file-only imports
This overhauls `exprFromPath` (and every function downstream of that) to
speed up imports when no URLs are imported.

Previously, Dhall would always demand a `Manager` on the very first
import, whether or not Dhall actually needed to fetch a remote URL.
Fetching this `Manager` adds an unusually long overhead (~1 s) to
programs that only needed to fetch local files.

Now the `Manager` is only requested as late as possible (i.e. right
before the first URL import)

@Gabriel439 Gabriel439 merged commit 6ff5852 into master Dec 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Gabriel439 Gabriel439 deleted the gabriel/faster_files branch Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment