Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for GHC 8.2 #1949

Merged
merged 18 commits into from
Jul 28, 2020
Merged

Drop support for GHC 8.2 #1949

merged 18 commits into from
Jul 28, 2020

Conversation

sjakobi
Copy link
Collaborator

@sjakobi sjakobi commented Jul 28, 2020

…and do some general cleanup of compatibility code.

Closes #1947.

@sjakobi sjakobi force-pushed the sjakobi/1947-drop-8.2-support branch from b883cf9 to fce85a3 Compare July 28, 2020 11:59
@Gabriella439
Copy link
Collaborator

Looks great so far! This cleans up the code a lot! 🙂

I think the main thing to check is to remove obsolete {-# LANGUAGE CPP #-} pragmas if you haven't already

Copy link
Collaborator

@german1608 german1608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjakobi sjakobi marked this pull request as ready for review July 28, 2020 19:23
@sjakobi sjakobi merged commit c3f6c40 into master Jul 28, 2020
@sjakobi sjakobi deleted the sjakobi/1947-drop-8.2-support branch July 28, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings related to Data.Monoid / Data.Semigroup
3 participants