Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dhall-text): add output file command line argument #1974

Merged
merged 3 commits into from
Aug 4, 2020

Conversation

TristanCacqueray
Copy link
Collaborator

This change enables setting a file output for the dhall text command
so that it is consistent with the other command that generate an
output.

This change enables setting a file output for the dhall text command
so that it is consistent with the other command that generate an
output.
@german1608
Copy link
Collaborator

Is this change relevant to dhall-docs? I believe it's just for the dhall executable. I'm asking because the title of the PR starts with feat(dhall-docs)...

@TristanCacqueray TristanCacqueray changed the title feat(dhall-docs): add output file command line argument feat(dhall-text): add output file command line argument Aug 4, 2020
@TristanCacqueray
Copy link
Collaborator Author

Oops, I meant dhall-text, sorry :-)

dhall/src/Dhall/Main.hs Outdated Show resolved Hide resolved
dhall/src/Dhall/Main.hs Outdated Show resolved Hide resolved
@TristanCacqueray
Copy link
Collaborator Author

Thanks for the review @german1608

@german1608
Copy link
Collaborator

Thanks for the review @german1608

@TristanCacqueray: you're welcome!

@mergify mergify bot merged commit 69dc28d into dhall-lang:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants