Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parser for projection by labels #2089

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Fix parser for projection by labels #2089

merged 1 commit into from
Nov 11, 2020

Conversation

Gabriella439
Copy link
Collaborator

… to not consume a trailing comma OUTSIDE of the braces.

Fixes #2088

The two alternatives for the labels parser already support
trailing commas INSIDE of the braces. The buggy line appears to
have been left behind by mistake.

This also left-factors the field projection parser, which is a
slight parsing performance improvement I noticed along the way.

… to not consume a trailing comma OUTSIDE of the braces.

Fixes #2088

The two alternatives for the labels parser already support
trailing commas INSIDE of the braces.  The buggy line appears to
have been left behind by mistake.

This also left-factors the field projection parser, which is a
slight parsing performance improvement I noticed along the way.
@Gabriella439
Copy link
Collaborator Author

Hmmm, doctests appear to be reliably failing for the appveyor build recently. I see the same issue on #2087

C:\projects\dhall-haskell\dhall\src/Dhall/Deriving.hs:281: failure in expression `:{
font :: Decoder Font
font =
  union
    (  (Arial         <$ constructor "Arial"           unit)
    <> (ComicSans     <$ constructor "Comic Sans"      unit)
    <> (Helvetica     <$ constructor "Helvetica"       unit)
    <> (TimesNewRoman <$ constructor "Times New Roman" unit)
    )
:}'
expected: 
 but got: "<interactive>: addLibrarySearchPath: C:\\Users\\appveyor\\AppData\\Local\\Programs\\stack\\x86_64-windows\\msys2-20180531\\mingw64\\bin (Win32 error 3): The system cannot find the path specified.\r"
          "<interactive>: addLibrarySearchPath: C:\\Users\\appveyor\\AppData\\Local\\Programs\\stack\\x86_64-windows\\msys2-20180531\\mingw64\\lib (Win32 error 3): The system cannot find the path specified.\r"
          "<interactive>: addLibrarySearchPath: C:\\Users\\appveyor\\AppData\\Local\\Programs\\stack\\x86_64-windows\\msys2-20180531\\mingw64\\bin (Win32 error 3): The system cannot find the path specified.\r"
          "<interactive>: addLibrarySearchPath: C:\\Users\\appveyoExamples: 253  Tried: 250  Errors: 0  Failures: 1

@Gabriella439
Copy link
Collaborator Author

I suspect that this is due to a bad build cache on Appveyor, so I'm going to attempt to follow the instructions here:

https://www.appveyor.com/docs/build-cache/#cleaning-up-cache

@Gabriella439
Copy link
Collaborator Author

Yeah, it turns out that it was an issue with the cache. For future reference, I managed to clear it out by running:

$ curl --verbose -X DELETE --header "Authorization: Bearer ${TOKEN}" https://ci.appveyor.com/api/projects/Gabriel439/dhall-haskell/buildcache

… and then restarted the Appveyor build, which now passes.

@Gabriella439 Gabriella439 merged commit e0fb25b into master Nov 11, 2020
@Gabriella439 Gabriella439 deleted the gabriel/2088 branch November 11, 2020 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List containing record projection fails to evaluate depending on whitespace
2 participants