Fix performance regression for with expressions
#2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Would it be possible to roll this into a patch release, or should we wait for |
|
@ggilmore: I can cut an early 1.37.1 release to get this fix out |
sjakobi
approved these changes
Dec 8, 2020
|
Awesome thank you! Also I don't know if this is the appropriate place to ask this, but is there a test that can be added to the suite that would catch this in the future? It might be tricky if the only indicator of an issue is the length of the execution time though. |
|
@ggilmore: Probably not. Anything that would causes tests to fail would be problematic when run on different machines (e.g. as part of Nixpkgs CI, for example) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2105